diff --git a/web/app/components/base/chat/chat/__tests__/hooks.spec.tsx b/web/app/components/base/chat/chat/__tests__/hooks.spec.tsx index 92fa9ea42e..097986a4e6 100644 --- a/web/app/components/base/chat/chat/__tests__/hooks.spec.tsx +++ b/web/app/components/base/chat/chat/__tests__/hooks.spec.tsx @@ -588,6 +588,66 @@ describe('useChat', () => { expect(lastResponse.workflowProcess?.status).toBe('failed') }) + it('should keep separate iteration traces for repeated executions of the same iteration node', async () => { + let callbacks: HookCallbacks + + vi.mocked(ssePost).mockImplementation(async (_url, _params, options) => { + callbacks = options as HookCallbacks + }) + + const { result } = renderHook(() => useChat()) + + act(() => { + result.current.handleSend('test-url', { query: 'iteration trace test' }, {}) + }) + + act(() => { + callbacks.onWorkflowStarted({ workflow_run_id: 'wr-1', task_id: 't-1' }) + callbacks.onIterationStart({ data: { id: 'iter-run-1', node_id: 'iter-1' } }) + callbacks.onIterationStart({ data: { id: 'iter-run-2', node_id: 'iter-1' } }) + callbacks.onIterationFinish({ data: { id: 'iter-run-1', node_id: 'iter-1', status: 'succeeded' } }) + callbacks.onIterationFinish({ data: { id: 'iter-run-2', node_id: 'iter-1', status: 'succeeded' } }) + }) + + const tracing = result.current.chatList[1].workflowProcess?.tracing ?? [] + + expect(tracing).toHaveLength(2) + expect(tracing).toEqual(expect.arrayContaining([ + expect.objectContaining({ id: 'iter-run-1', status: 'succeeded' }), + expect.objectContaining({ id: 'iter-run-2', status: 'succeeded' }), + ])) + }) + + it('should keep separate top-level traces for repeated executions of the same node', async () => { + let callbacks: HookCallbacks + + vi.mocked(ssePost).mockImplementation(async (_url, _params, options) => { + callbacks = options as HookCallbacks + }) + + const { result } = renderHook(() => useChat()) + + act(() => { + result.current.handleSend('test-url', { query: 'top-level trace test' }, {}) + }) + + act(() => { + callbacks.onWorkflowStarted({ workflow_run_id: 'wr-1', task_id: 't-1' }) + callbacks.onNodeStarted({ data: { id: 'node-run-1', node_id: 'node-1', title: 'Node 1' } }) + callbacks.onNodeStarted({ data: { id: 'node-run-2', node_id: 'node-1', title: 'Node 1 retry' } }) + callbacks.onNodeFinished({ data: { id: 'node-run-1', node_id: 'node-1', status: 'succeeded' } }) + callbacks.onNodeFinished({ data: { id: 'node-run-2', node_id: 'node-1', status: 'succeeded' } }) + }) + + const tracing = result.current.chatList[1].workflowProcess?.tracing ?? [] + + expect(tracing).toHaveLength(2) + expect(tracing).toEqual(expect.arrayContaining([ + expect.objectContaining({ id: 'node-run-1', status: 'succeeded' }), + expect.objectContaining({ id: 'node-run-2', status: 'succeeded' }), + ])) + }) + it('should handle early exits in tracing events during iteration or loop', async () => { let callbacks: HookCallbacks @@ -623,7 +683,7 @@ describe('useChat', () => { callbacks.onNodeFinished({ data: { id: 'n-1', iteration_id: 'iter-1' } }) }) - const traceLen1 = result.current.chatList[result.current.chatList.length - 1].workflowProcess?.tracing?.length + const traceLen1 = result.current.chatList.at(-1)!.workflowProcess?.tracing?.length expect(traceLen1).toBe(0) // None added due to iteration early hits }) @@ -707,7 +767,7 @@ describe('useChat', () => { expect(result.current.chatList.some(item => item.id === 'question-m-child')).toBe(true) expect(result.current.chatList.some(item => item.id === 'm-child')).toBe(true) - expect(result.current.chatList[result.current.chatList.length - 1].content).toBe('child answer') + expect(result.current.chatList.at(-1)!.content).toBe('child answer') }) it('should strip local file urls before sending payload', () => { @@ -805,7 +865,7 @@ describe('useChat', () => { }) expect(onGetConversationMessages).toHaveBeenCalled() - expect(result.current.chatList[result.current.chatList.length - 1].content).toBe('streamed content') + expect(result.current.chatList.at(-1)!.content).toBe('streamed content') }) it('should clear suggested questions when suggestion fetch fails after completion', async () => { @@ -851,7 +911,7 @@ describe('useChat', () => { callbacks.onNodeFinished({ data: { node_id: 'n-loop', id: 'n-loop' } }) }) - const latestResponse = result.current.chatList[result.current.chatList.length - 1] + const latestResponse = result.current.chatList.at(-1)! expect(latestResponse.workflowProcess?.tracing).toHaveLength(0) }) @@ -878,7 +938,7 @@ describe('useChat', () => { callbacks.onTTSChunk('m-th-bind', '') }) - const latestResponse = result.current.chatList[result.current.chatList.length - 1] + const latestResponse = result.current.chatList.at(-1)! expect(latestResponse.id).toBe('m-th-bind') expect(latestResponse.conversationId).toBe('c-th-bind') expect(latestResponse.workflowProcess?.status).toBe('succeeded') @@ -971,7 +1031,7 @@ describe('useChat', () => { callbacks.onCompleted() }) - const lastResponse = result.current.chatList[result.current.chatList.length - 1] + const lastResponse = result.current.chatList.at(-1)! expect(lastResponse.agent_thoughts![0].thought).toContain('resumed') expect(lastResponse.workflowProcess?.tracing?.length).toBeGreaterThan(0) diff --git a/web/app/components/base/chat/chat/hooks.ts b/web/app/components/base/chat/chat/hooks.ts index a0f335f567..1807eadc0f 100644 --- a/web/app/components/base/chat/chat/hooks.ts +++ b/web/app/components/base/chat/chat/hooks.ts @@ -12,6 +12,7 @@ import type { IOnDataMoreInfo, IOtherOptions, } from '@/service/base' +import type { NodeTracing } from '@/types/workflow' import { uniqBy } from 'es-toolkit/compat' import { noop } from 'es-toolkit/function' import { produce, setAutoFreeze } from 'immer' @@ -31,6 +32,7 @@ import { } from '@/app/components/base/file-uploader/utils' import { useToastContext } from '@/app/components/base/toast/context' import { NodeRunningStatus, WorkflowRunningStatus } from '@/app/components/workflow/types' +import { upsertTopLevelTracingNodeOnStart } from '@/app/components/workflow/utils/top-level-tracing' import useTimestamp from '@/hooks/use-timestamp' import { useParams, usePathname } from '@/next/navigation' import { @@ -52,6 +54,39 @@ type SendCallback = { isPublicAPI?: boolean } +type ParallelTraceLike = Pick + +const findParallelTraceIndex = ( + tracing: ParallelTraceLike[], + data: Partial, +) => { + const incomingParallelId = data.execution_metadata?.parallel_id ?? data.parallel_id + + if (data.id) { + const matchedByIdIndex = tracing.findIndex((item) => { + if (item.id !== data.id) + return false + + const existingParallelId = item.execution_metadata?.parallel_id ?? item.parallel_id + if (!existingParallelId || !incomingParallelId) + return true + + return existingParallelId === incomingParallelId + }) + + if (matchedByIdIndex > -1) + return matchedByIdIndex + } + + return tracing.findIndex((item) => { + if (item.node_id !== data.node_id) + return false + + const existingParallelId = item.execution_metadata?.parallel_id ?? item.parallel_id + return existingParallelId === incomingParallelId + }) +} + export const useChat = ( config?: ChatConfig, formSettings?: { @@ -419,8 +454,7 @@ export const useChat = ( if (!responseItem.workflowProcess?.tracing) return const tracing = responseItem.workflowProcess.tracing - const iterationIndex = tracing.findIndex(item => item.node_id === iterationFinishedData.node_id - && (item.execution_metadata?.parallel_id === iterationFinishedData.execution_metadata?.parallel_id || item.parallel_id === iterationFinishedData.execution_metadata?.parallel_id))! + const iterationIndex = findParallelTraceIndex(tracing, iterationFinishedData) if (iterationIndex > -1) { tracing[iterationIndex] = { ...tracing[iterationIndex], @@ -432,38 +466,34 @@ export const useChat = ( }, onNodeStarted: ({ data: nodeStartedData }) => { updateChatTreeNode(messageId, (responseItem) => { + if (params.loop_id) + return + if (!responseItem.workflowProcess) return if (!responseItem.workflowProcess.tracing) responseItem.workflowProcess.tracing = [] - const currentIndex = responseItem.workflowProcess.tracing.findIndex(item => item.node_id === nodeStartedData.node_id) - // if the node is already started, update the node - if (currentIndex > -1) { - responseItem.workflowProcess.tracing[currentIndex] = { - ...nodeStartedData, - status: NodeRunningStatus.Running, - } - } - else { - if (nodeStartedData.iteration_id) - return - - responseItem.workflowProcess.tracing.push({ - ...nodeStartedData, - status: WorkflowRunningStatus.Running, - }) - } + upsertTopLevelTracingNodeOnStart(responseItem.workflowProcess.tracing, { + ...nodeStartedData, + status: NodeRunningStatus.Running, + }) }) }, onNodeFinished: ({ data: nodeFinishedData }) => { updateChatTreeNode(messageId, (responseItem) => { + if (params.loop_id) + return + if (!responseItem.workflowProcess?.tracing) return if (nodeFinishedData.iteration_id) return + if (nodeFinishedData.loop_id) + return + const currentIndex = responseItem.workflowProcess.tracing.findIndex((item) => { if (!item.execution_metadata?.parallel_id) return item.id === nodeFinishedData.id @@ -505,8 +535,7 @@ export const useChat = ( if (!responseItem.workflowProcess?.tracing) return const tracing = responseItem.workflowProcess.tracing - const loopIndex = tracing.findIndex(item => item.node_id === loopFinishedData.node_id - && (item.execution_metadata?.parallel_id === loopFinishedData.execution_metadata?.parallel_id || item.parallel_id === loopFinishedData.execution_metadata?.parallel_id))! + const loopIndex = findParallelTraceIndex(tracing, loopFinishedData) if (loopIndex > -1) { tracing[loopIndex] = { ...tracing[loopIndex], @@ -582,7 +611,7 @@ export const useChat = ( {}, otherOptions, ) - }, [updateChatTreeNode, handleResponding, createAudioPlayerManager, config?.suggested_questions_after_answer]) + }, [updateChatTreeNode, handleResponding, createAudioPlayerManager, config?.suggested_questions_after_answer, params.loop_id]) const updateCurrentQAOnTree = useCallback(({ parentId, @@ -972,12 +1001,13 @@ export const useChat = ( }, onIterationFinish: ({ data: iterationFinishedData }) => { const tracing = responseItem.workflowProcess!.tracing! - const iterationIndex = tracing.findIndex(item => item.node_id === iterationFinishedData.node_id - && (item.execution_metadata?.parallel_id === iterationFinishedData.execution_metadata?.parallel_id || item.parallel_id === iterationFinishedData.execution_metadata?.parallel_id))! - tracing[iterationIndex] = { - ...tracing[iterationIndex], - ...iterationFinishedData, - status: WorkflowRunningStatus.Succeeded, + const iterationIndex = findParallelTraceIndex(tracing, iterationFinishedData) + if (iterationIndex > -1) { + tracing[iterationIndex] = { + ...tracing[iterationIndex], + ...iterationFinishedData, + status: WorkflowRunningStatus.Succeeded, + } } updateCurrentQAOnTree({ @@ -988,30 +1018,19 @@ export const useChat = ( }) }, onNodeStarted: ({ data: nodeStartedData }) => { + // `data` is the outer send payload for this request; loop child runs should not emit top-level node traces here. + if (data.loop_id) + return + if (!responseItem.workflowProcess) return if (!responseItem.workflowProcess.tracing) responseItem.workflowProcess.tracing = [] - const currentIndex = responseItem.workflowProcess.tracing.findIndex(item => item.node_id === nodeStartedData.node_id) - if (currentIndex > -1) { - responseItem.workflowProcess.tracing[currentIndex] = { - ...nodeStartedData, - status: NodeRunningStatus.Running, - } - } - else { - if (nodeStartedData.iteration_id) - return - - if (data.loop_id) - return - - responseItem.workflowProcess.tracing.push({ - ...nodeStartedData, - status: WorkflowRunningStatus.Running, - }) - } + upsertTopLevelTracingNodeOnStart(responseItem.workflowProcess.tracing, { + ...nodeStartedData, + status: NodeRunningStatus.Running, + }) updateCurrentQAOnTree({ placeholderQuestionId, questionItem, @@ -1020,10 +1039,14 @@ export const useChat = ( }) }, onNodeFinished: ({ data: nodeFinishedData }) => { + // Use the outer request payload here as well so loop child runs skip top-level finish handling entirely. + if (data.loop_id) + return + if (nodeFinishedData.iteration_id) return - if (data.loop_id) + if (nodeFinishedData.loop_id) return const currentIndex = responseItem.workflowProcess!.tracing!.findIndex((item) => { @@ -1069,12 +1092,13 @@ export const useChat = ( }, onLoopFinish: ({ data: loopFinishedData }) => { const tracing = responseItem.workflowProcess!.tracing! - const loopIndex = tracing.findIndex(item => item.node_id === loopFinishedData.node_id - && (item.execution_metadata?.parallel_id === loopFinishedData.execution_metadata?.parallel_id || item.parallel_id === loopFinishedData.execution_metadata?.parallel_id))! - tracing[loopIndex] = { - ...tracing[loopIndex], - ...loopFinishedData, - status: WorkflowRunningStatus.Succeeded, + const loopIndex = findParallelTraceIndex(tracing, loopFinishedData) + if (loopIndex > -1) { + tracing[loopIndex] = { + ...tracing[loopIndex], + ...loopFinishedData, + status: WorkflowRunningStatus.Succeeded, + } } updateCurrentQAOnTree({ diff --git a/web/app/components/datasets/create/website/jina-reader/__tests__/base.spec.tsx b/web/app/components/datasets/create/website/jina-reader/__tests__/base.spec.tsx index bcfcf39060..953604e5c6 100644 --- a/web/app/components/datasets/create/website/jina-reader/__tests__/base.spec.tsx +++ b/web/app/components/datasets/create/website/jina-reader/__tests__/base.spec.tsx @@ -264,7 +264,7 @@ describe('UrlInput', () => { render() const input = screen.getByRole('textbox') - await userEvent.type(input, longUrl) + fireEvent.change(input, { target: { value: longUrl } }) expect(input).toHaveValue(longUrl) }) @@ -275,7 +275,7 @@ describe('UrlInput', () => { render() const input = screen.getByRole('textbox') - await userEvent.type(input, unicodeUrl) + fireEvent.change(input, { target: { value: unicodeUrl } }) expect(input).toHaveValue(unicodeUrl) }) @@ -285,7 +285,7 @@ describe('UrlInput', () => { render() const input = screen.getByRole('textbox') - await userEvent.type(input, 'https://rapid.com', { delay: 1 }) + fireEvent.change(input, { target: { value: 'https://rapid.com' } }) expect(input).toHaveValue('https://rapid.com') }) @@ -297,7 +297,7 @@ describe('UrlInput', () => { render() const input = screen.getByRole('textbox') - await userEvent.type(input, 'https://enter.com') + fireEvent.change(input, { target: { value: 'https://enter.com' } }) // Focus button and press enter const button = screen.getByRole('button', { name: /run/i }) diff --git a/web/app/components/datasets/list/dataset-card/hooks/__tests__/use-dataset-card-state.spec.ts b/web/app/components/datasets/list/dataset-card/hooks/__tests__/use-dataset-card-state.spec.ts index f29d85b460..935f1329d1 100644 --- a/web/app/components/datasets/list/dataset-card/hooks/__tests__/use-dataset-card-state.spec.ts +++ b/web/app/components/datasets/list/dataset-card/hooks/__tests__/use-dataset-card-state.spec.ts @@ -157,7 +157,7 @@ describe('useDatasetCardState', () => { expect(result.current.modalState.showRenameModal).toBe(false) }) - it('should close confirm delete modal when closeConfirmDelete is called', () => { + it('should close confirm delete modal when closeConfirmDelete is called', async () => { const dataset = createMockDataset() const { result } = renderHook(() => useDatasetCardState({ dataset, onSuccess: vi.fn() }), @@ -168,7 +168,7 @@ describe('useDatasetCardState', () => { result.current.detectIsUsedByApp() }) - waitFor(() => { + await waitFor(() => { expect(result.current.modalState.showConfirmDelete).toBe(true) }) diff --git a/web/app/components/share/text-generation/result/__tests__/workflow-stream-handlers.spec.ts b/web/app/components/share/text-generation/result/__tests__/workflow-stream-handlers.spec.ts index 45d5ded302..db6af0dc84 100644 --- a/web/app/components/share/text-generation/result/__tests__/workflow-stream-handlers.spec.ts +++ b/web/app/components/share/text-generation/result/__tests__/workflow-stream-handlers.spec.ts @@ -101,6 +101,7 @@ const createHumanInput = (overrides: Partial = {}): HumanInp describe('workflow-stream-handlers helpers', () => { it('should update tracing, result text, and human input state', () => { const parallelTrace = createTrace({ + id: 'parallel-trace-1', node_id: 'parallel-node', execution_metadata: { parallel_id: 'parallel-1' }, details: [[]], @@ -109,11 +110,13 @@ describe('workflow-stream-handlers helpers', () => { let workflowProcessData = appendParallelStart(undefined, parallelTrace) workflowProcessData = appendParallelNext(workflowProcessData, parallelTrace) workflowProcessData = finishParallelTrace(workflowProcessData, createTrace({ + id: 'parallel-trace-1', node_id: 'parallel-node', execution_metadata: { parallel_id: 'parallel-1' }, error: 'failed', })) workflowProcessData = upsertWorkflowNode(workflowProcessData, createTrace({ + id: 'node-trace-1', node_id: 'node-1', execution_metadata: { parallel_id: 'parallel-2' }, }))! @@ -160,6 +163,129 @@ describe('workflow-stream-handlers helpers', () => { expect(nextProcess.tracing[0]?.details).toEqual([[], []]) }) + it('should keep separate iteration and loop traces for repeated executions with different ids', () => { + const process = createWorkflowProcess() + process.tracing = [ + createTrace({ + id: 'iter-trace-1', + node_id: 'iter-1', + details: [[]], + }), + createTrace({ + id: 'iter-trace-2', + node_id: 'iter-1', + details: [[]], + }), + createTrace({ + id: 'loop-trace-1', + node_id: 'loop-1', + details: [[]], + }), + createTrace({ + id: 'loop-trace-2', + node_id: 'loop-1', + details: [[]], + }), + ] + + const iterNextProcess = appendParallelNext(process, createTrace({ + id: 'iter-trace-2', + node_id: 'iter-1', + })) + const iterFinishedProcess = finishParallelTrace(iterNextProcess, createTrace({ + id: 'iter-trace-2', + node_id: 'iter-1', + status: NodeRunningStatus.Succeeded, + details: undefined, + })) + const loopNextProcess = appendParallelNext(iterFinishedProcess, createTrace({ + id: 'loop-trace-2', + node_id: 'loop-1', + })) + const loopFinishedProcess = finishParallelTrace(loopNextProcess, createTrace({ + id: 'loop-trace-2', + node_id: 'loop-1', + status: NodeRunningStatus.Succeeded, + details: undefined, + })) + + expect(loopFinishedProcess.tracing[0]).toEqual(expect.objectContaining({ + id: 'iter-trace-1', + details: [[]], + status: NodeRunningStatus.Running, + })) + expect(loopFinishedProcess.tracing[1]).toEqual(expect.objectContaining({ + id: 'iter-trace-2', + details: [[], []], + status: NodeRunningStatus.Succeeded, + })) + expect(loopFinishedProcess.tracing[2]).toEqual(expect.objectContaining({ + id: 'loop-trace-1', + details: [[]], + status: NodeRunningStatus.Running, + })) + expect(loopFinishedProcess.tracing[3]).toEqual(expect.objectContaining({ + id: 'loop-trace-2', + details: [[], []], + status: NodeRunningStatus.Succeeded, + })) + }) + + it('should append a new top-level trace when the same node starts with a different execution id', () => { + const process = createWorkflowProcess() + process.tracing = [ + createTrace({ + id: 'trace-1', + node_id: 'node-1', + status: NodeRunningStatus.Succeeded, + }), + ] + + const updatedProcess = upsertWorkflowNode(process, createTrace({ + id: 'trace-2', + node_id: 'node-1', + }))! + + expect(updatedProcess.tracing).toHaveLength(2) + expect(updatedProcess.tracing[1]).toEqual(expect.objectContaining({ + id: 'trace-2', + node_id: 'node-1', + status: NodeRunningStatus.Running, + })) + }) + + it('should finish the matching top-level trace when the same node runs again with a new execution id', () => { + const process = createWorkflowProcess() + process.tracing = [ + createTrace({ + id: 'trace-1', + node_id: 'node-1', + status: NodeRunningStatus.Succeeded, + }), + createTrace({ + id: 'trace-2', + node_id: 'node-1', + status: NodeRunningStatus.Running, + }), + ] + + const updatedProcess = finishWorkflowNode(process, createTrace({ + id: 'trace-2', + node_id: 'node-1', + status: NodeRunningStatus.Succeeded, + }))! + + expect(updatedProcess.tracing).toHaveLength(2) + expect(updatedProcess.tracing[0]).toEqual(expect.objectContaining({ + id: 'trace-1', + status: NodeRunningStatus.Succeeded, + })) + expect(updatedProcess.tracing[1]).toEqual(expect.objectContaining({ + id: 'trace-2', + status: NodeRunningStatus.Succeeded, + })) + }) + it('should leave tracing unchanged when a parallel next event has no matching trace', () => { const process = createWorkflowProcess() process.tracing = [ @@ -171,6 +297,7 @@ describe('workflow-stream-handlers helpers', () => { ] const nextProcess = appendParallelNext(process, createTrace({ + id: 'trace-missing', node_id: 'missing-node', execution_metadata: { parallel_id: 'parallel-2' }, })) @@ -228,6 +355,7 @@ describe('workflow-stream-handlers helpers', () => { }, })) const notFinished = finishParallelTrace(process, createTrace({ + id: 'trace-missing', node_id: 'missing', execution_metadata: { parallel_id: 'parallel-missing', @@ -243,6 +371,7 @@ describe('workflow-stream-handlers helpers', () => { loop_id: 'loop-1', })) const unmatchedFinish = finishWorkflowNode(process, createTrace({ + id: 'trace-missing', node_id: 'missing', execution_metadata: { parallel_id: 'missing', diff --git a/web/app/components/share/text-generation/result/workflow-stream-handlers.ts b/web/app/components/share/text-generation/result/workflow-stream-handlers.ts index 48b132587e..ef8418f9fa 100644 --- a/web/app/components/share/text-generation/result/workflow-stream-handlers.ts +++ b/web/app/components/share/text-generation/result/workflow-stream-handlers.ts @@ -5,6 +5,7 @@ import type { HumanInputFormTimeoutData, NodeTracing, WorkflowFinishedResponse } import { produce } from 'immer' import { getFilesInLogs } from '@/app/components/base/file-uploader/utils' import { NodeRunningStatus, WorkflowRunningStatus } from '@/app/components/workflow/types' +import { upsertTopLevelTracingNodeOnStart } from '@/app/components/workflow/utils/top-level-tracing' import { sseGet } from '@/service/base' type Notify = (payload: { type: 'error' | 'warning', message: string }) => void @@ -49,6 +50,15 @@ const matchParallelTrace = (trace: WorkflowProcess['tracing'][number], data: Nod || trace.parallel_id === data.execution_metadata?.parallel_id) } +const findParallelTraceIndex = (tracing: WorkflowProcess['tracing'], data: NodeTracing) => { + return tracing.findIndex((trace) => { + if (trace.id && data.id) + return trace.id === data.id + + return matchParallelTrace(trace, data) + }) +} + const ensureParallelTraceDetails = (details?: NodeTracing['details']) => { return details?.length ? details : [[]] } @@ -68,7 +78,8 @@ const appendParallelStart = (current: WorkflowProcess | undefined, data: NodeTra const appendParallelNext = (current: WorkflowProcess | undefined, data: NodeTracing) => { return updateWorkflowProcess(current, (draft) => { draft.expand = true - const trace = draft.tracing.find(item => matchParallelTrace(item, data)) + const traceIndex = findParallelTraceIndex(draft.tracing, data) + const trace = draft.tracing[traceIndex] if (!trace) return @@ -80,10 +91,13 @@ const appendParallelNext = (current: WorkflowProcess | undefined, data: NodeTrac const finishParallelTrace = (current: WorkflowProcess | undefined, data: NodeTracing) => { return updateWorkflowProcess(current, (draft) => { draft.expand = true - const traceIndex = draft.tracing.findIndex(item => matchParallelTrace(item, data)) + const traceIndex = findParallelTraceIndex(draft.tracing, data) if (traceIndex > -1) { + const currentTrace = draft.tracing[traceIndex] draft.tracing[traceIndex] = { + ...currentTrace, ...data, + details: data.details ?? currentTrace.details, expand: !!data.error, } } @@ -96,17 +110,22 @@ const upsertWorkflowNode = (current: WorkflowProcess | undefined, data: NodeTrac return updateWorkflowProcess(current, (draft) => { draft.expand = true - const currentIndex = draft.tracing.findIndex(item => item.node_id === data.node_id) const nextTrace = { ...data, status: NodeRunningStatus.Running, expand: true, } - if (currentIndex > -1) - draft.tracing[currentIndex] = nextTrace - else - draft.tracing.push(nextTrace) + upsertTopLevelTracingNodeOnStart(draft.tracing, nextTrace) + }) +} + +const findWorkflowNodeTraceIndex = (tracing: WorkflowProcess['tracing'], data: NodeTracing) => { + return tracing.findIndex((trace) => { + if (trace.id && data.id) + return trace.id === data.id + + return matchParallelTrace(trace, data) }) } @@ -115,7 +134,7 @@ const finishWorkflowNode = (current: WorkflowProcess | undefined, data: NodeTrac return current return updateWorkflowProcess(current, (draft) => { - const currentIndex = draft.tracing.findIndex(trace => matchParallelTrace(trace, data)) + const currentIndex = findWorkflowNodeTraceIndex(draft.tracing, data) if (currentIndex > -1) { draft.tracing[currentIndex] = { ...(draft.tracing[currentIndex].extras diff --git a/web/app/components/workflow/hooks/__tests__/use-workflow-run-event-store-only.spec.ts b/web/app/components/workflow/hooks/__tests__/use-workflow-run-event-store-only.spec.ts index 2085e5ab47..8574047e70 100644 --- a/web/app/components/workflow/hooks/__tests__/use-workflow-run-event-store-only.spec.ts +++ b/web/app/components/workflow/hooks/__tests__/use-workflow-run-event-store-only.spec.ts @@ -109,13 +109,13 @@ describe('useWorkflowAgentLog', () => { const { result, store } = renderWorkflowHook(() => useWorkflowAgentLog(), { initialStoreState: { workflowRunningData: baseRunningData({ - tracing: [{ node_id: 'n1', execution_metadata: {} }], + tracing: [{ id: 'trace-1', node_id: 'n1', execution_metadata: {} }], }), }, }) result.current.handleWorkflowAgentLog({ - data: { node_id: 'n1', message_id: 'm1' }, + data: { node_id: 'n1', node_execution_id: 'trace-1', message_id: 'm1' }, } as AgentLogResponse) const trace = store.getState().workflowRunningData!.tracing![0] @@ -128,6 +128,7 @@ describe('useWorkflowAgentLog', () => { initialStoreState: { workflowRunningData: baseRunningData({ tracing: [{ + id: 'trace-1', node_id: 'n1', execution_metadata: { agent_log: [{ message_id: 'm1', text: 'log1' }] }, }], @@ -136,7 +137,7 @@ describe('useWorkflowAgentLog', () => { }) result.current.handleWorkflowAgentLog({ - data: { node_id: 'n1', message_id: 'm2' }, + data: { node_id: 'n1', node_execution_id: 'trace-1', message_id: 'm2' }, } as AgentLogResponse) expect(store.getState().workflowRunningData!.tracing![0].execution_metadata!.agent_log).toHaveLength(2) @@ -147,6 +148,7 @@ describe('useWorkflowAgentLog', () => { initialStoreState: { workflowRunningData: baseRunningData({ tracing: [{ + id: 'trace-1', node_id: 'n1', execution_metadata: { agent_log: [{ message_id: 'm1', text: 'old' }] }, }], @@ -155,7 +157,7 @@ describe('useWorkflowAgentLog', () => { }) result.current.handleWorkflowAgentLog({ - data: { node_id: 'n1', message_id: 'm1', text: 'new' }, + data: { node_id: 'n1', node_execution_id: 'trace-1', message_id: 'm1', text: 'new' }, } as unknown as AgentLogResponse) const log = store.getState().workflowRunningData!.tracing![0].execution_metadata!.agent_log! @@ -167,17 +169,39 @@ describe('useWorkflowAgentLog', () => { const { result, store } = renderWorkflowHook(() => useWorkflowAgentLog(), { initialStoreState: { workflowRunningData: baseRunningData({ - tracing: [{ node_id: 'n1' }], + tracing: [{ id: 'trace-1', node_id: 'n1' }], }), }, }) result.current.handleWorkflowAgentLog({ - data: { node_id: 'n1', message_id: 'm1' }, + data: { node_id: 'n1', node_execution_id: 'trace-1', message_id: 'm1' }, } as AgentLogResponse) expect(store.getState().workflowRunningData!.tracing![0].execution_metadata!.agent_log).toHaveLength(1) }) + + it('should attach the log to the matching execution id when a node runs multiple times', () => { + const { result, store } = renderWorkflowHook(() => useWorkflowAgentLog(), { + initialStoreState: { + workflowRunningData: baseRunningData({ + tracing: [ + { id: 'trace-1', node_id: 'n1', execution_metadata: {} }, + { id: 'trace-2', node_id: 'n1', execution_metadata: {} }, + ], + }), + }, + }) + + result.current.handleWorkflowAgentLog({ + data: { node_id: 'n1', node_execution_id: 'trace-2', message_id: 'm2' }, + } as AgentLogResponse) + + const tracing = store.getState().workflowRunningData!.tracing! + expect(tracing[0].execution_metadata!.agent_log).toBeUndefined() + expect(tracing[1].execution_metadata!.agent_log).toHaveLength(1) + expect(tracing[1].execution_metadata!.agent_log![0].message_id).toBe('m2') + }) }) describe('useWorkflowNodeHumanInputFormFilled', () => { diff --git a/web/app/components/workflow/hooks/__tests__/use-workflow-run-event-with-viewport.spec.ts b/web/app/components/workflow/hooks/__tests__/use-workflow-run-event-with-viewport.spec.ts index 73b16acf2e..b1cd8a0136 100644 --- a/web/app/components/workflow/hooks/__tests__/use-workflow-run-event-with-viewport.spec.ts +++ b/web/app/components/workflow/hooks/__tests__/use-workflow-run-event-with-viewport.spec.ts @@ -109,7 +109,7 @@ describe('useWorkflowNodeStarted', () => { act(() => { result.current.handleWorkflowNodeStarted( - { data: { node_id: 'n1' } } as NodeStartedResponse, + { data: { id: 'trace-n1', node_id: 'n1' } } as NodeStartedResponse, containerParams, ) }) @@ -138,7 +138,7 @@ describe('useWorkflowNodeStarted', () => { act(() => { result.current.handleWorkflowNodeStarted( - { data: { node_id: 'n2' } } as NodeStartedResponse, + { data: { id: 'trace-n2', node_id: 'n2' } } as NodeStartedResponse, containerParams, ) }) @@ -157,8 +157,8 @@ describe('useWorkflowNodeStarted', () => { initialStoreState: { workflowRunningData: baseRunningData({ tracing: [ - { node_id: 'n0', status: NodeRunningStatus.Succeeded }, - { node_id: 'n1', status: NodeRunningStatus.Succeeded }, + { id: 'trace-0', node_id: 'n0', status: NodeRunningStatus.Succeeded }, + { id: 'trace-1', node_id: 'n1', status: NodeRunningStatus.Succeeded }, ], }), }, @@ -166,7 +166,7 @@ describe('useWorkflowNodeStarted', () => { act(() => { result.current.handleWorkflowNodeStarted( - { data: { node_id: 'n1' } } as NodeStartedResponse, + { data: { id: 'trace-1', node_id: 'n1' } } as NodeStartedResponse, containerParams, ) }) @@ -175,6 +175,32 @@ describe('useWorkflowNodeStarted', () => { expect(tracing).toHaveLength(2) expect(tracing[1].status).toBe(NodeRunningStatus.Running) }) + + it('should append a new tracing entry when the same node starts a new execution id', () => { + const { result, store } = renderViewportHook(() => useWorkflowNodeStarted(), { + initialStoreState: { + workflowRunningData: baseRunningData({ + tracing: [ + { id: 'trace-0', node_id: 'n0', status: NodeRunningStatus.Succeeded }, + { id: 'trace-1', node_id: 'n1', status: NodeRunningStatus.Succeeded }, + ], + }), + }, + }) + + act(() => { + result.current.handleWorkflowNodeStarted( + { data: { id: 'trace-2', node_id: 'n1' } } as NodeStartedResponse, + containerParams, + ) + }) + + const tracing = store.getState().workflowRunningData!.tracing! + expect(tracing).toHaveLength(3) + expect(tracing[2].id).toBe('trace-2') + expect(tracing[2].node_id).toBe('n1') + expect(tracing[2].status).toBe(NodeRunningStatus.Running) + }) }) describe('useWorkflowNodeIterationStarted', () => { diff --git a/web/app/components/workflow/hooks/use-workflow-run-event/use-workflow-agent-log.ts b/web/app/components/workflow/hooks/use-workflow-run-event/use-workflow-agent-log.ts index 08fb526000..a1a94df361 100644 --- a/web/app/components/workflow/hooks/use-workflow-run-event/use-workflow-agent-log.ts +++ b/web/app/components/workflow/hooks/use-workflow-run-event/use-workflow-agent-log.ts @@ -14,7 +14,7 @@ export const useWorkflowAgentLog = () => { } = workflowStore.getState() setWorkflowRunningData(produce(workflowRunningData!, (draft) => { - const currentIndex = draft.tracing!.findIndex(item => item.node_id === data.node_id) + const currentIndex = draft.tracing!.findIndex(item => item.id === data.node_execution_id) if (currentIndex > -1) { const current = draft.tracing![currentIndex] diff --git a/web/app/components/workflow/hooks/use-workflow-run-event/use-workflow-node-started.ts b/web/app/components/workflow/hooks/use-workflow-run-event/use-workflow-node-started.ts index 01f60e12e9..1528a99468 100644 --- a/web/app/components/workflow/hooks/use-workflow-run-event/use-workflow-node-started.ts +++ b/web/app/components/workflow/hooks/use-workflow-run-event/use-workflow-node-started.ts @@ -33,8 +33,8 @@ export const useWorkflowNodeStarted = () => { transform, } = store.getState() const nodes = getNodes() - const currentIndex = workflowRunningData?.tracing?.findIndex(item => item.node_id === data.node_id) - if (currentIndex && currentIndex > -1) { + const currentIndex = workflowRunningData?.tracing?.findIndex(item => item.id === data.id) + if (currentIndex !== undefined && currentIndex > -1) { setWorkflowRunningData(produce(workflowRunningData!, (draft) => { draft.tracing![currentIndex] = { ...data, diff --git a/web/app/components/workflow/panel/debug-and-preview/hooks.ts b/web/app/components/workflow/panel/debug-and-preview/hooks.ts index fe4ffda4da..37c7df24b9 100644 --- a/web/app/components/workflow/panel/debug-and-preview/hooks.ts +++ b/web/app/components/workflow/panel/debug-and-preview/hooks.ts @@ -42,6 +42,7 @@ import { import { useHooksStore } from '../../hooks-store' import { useWorkflowStore } from '../../store' import { NodeRunningStatus, WorkflowRunningStatus } from '../../types' +import { upsertTopLevelTracingNodeOnStart } from '../../utils/top-level-tracing' type GetAbortController = (abortController: AbortController) => void type SendCallback = { @@ -509,19 +510,13 @@ export const useChat = ( } }, onNodeStarted: ({ data }) => { - const currentIndex = responseItem.workflowProcess!.tracing!.findIndex(item => item.node_id === data.node_id) - if (currentIndex > -1) { - responseItem.workflowProcess!.tracing![currentIndex] = { - ...data, - status: NodeRunningStatus.Running, - } - } - else { - responseItem.workflowProcess!.tracing!.push({ - ...data, - status: NodeRunningStatus.Running, - }) - } + if (params.loop_id) + return + + upsertTopLevelTracingNodeOnStart(responseItem.workflowProcess!.tracing!, { + ...data, + status: NodeRunningStatus.Running, + }) updateCurrentQAOnTree({ placeholderQuestionId, questionItem, @@ -540,6 +535,9 @@ export const useChat = ( }) }, onNodeFinished: ({ data }) => { + if (params.loop_id) + return + const currentTracingIndex = responseItem.workflowProcess!.tracing!.findIndex(item => item.id === data.id) if (currentTracingIndex > -1) { responseItem.workflowProcess!.tracing[currentTracingIndex] = { @@ -555,7 +553,7 @@ export const useChat = ( } }, onAgentLog: ({ data }) => { - const currentNodeIndex = responseItem.workflowProcess!.tracing!.findIndex(item => item.node_id === data.node_id) + const currentNodeIndex = responseItem.workflowProcess!.tracing!.findIndex(item => item.id === data.node_execution_id) if (currentNodeIndex > -1) { const current = responseItem.workflowProcess!.tracing![currentNodeIndex] @@ -781,8 +779,7 @@ export const useChat = ( if (!responseItem.workflowProcess?.tracing) return const tracing = responseItem.workflowProcess.tracing - const iterationIndex = tracing.findIndex(item => item.node_id === iterationFinishedData.node_id - && (item.execution_metadata?.parallel_id === iterationFinishedData.execution_metadata?.parallel_id || item.parallel_id === iterationFinishedData.execution_metadata?.parallel_id))! + const iterationIndex = tracing.findIndex(item => item.id === iterationFinishedData.id)! if (iterationIndex > -1) { tracing[iterationIndex] = { ...tracing[iterationIndex], @@ -799,22 +796,10 @@ export const useChat = ( if (!responseItem.workflowProcess.tracing) responseItem.workflowProcess.tracing = [] - const currentIndex = responseItem.workflowProcess.tracing.findIndex(item => item.node_id === nodeStartedData.node_id) - if (currentIndex > -1) { - responseItem.workflowProcess.tracing[currentIndex] = { - ...nodeStartedData, - status: NodeRunningStatus.Running, - } - } - else { - if (nodeStartedData.iteration_id) - return - - responseItem.workflowProcess.tracing.push({ - ...nodeStartedData, - status: WorkflowRunningStatus.Running, - }) - } + upsertTopLevelTracingNodeOnStart(responseItem.workflowProcess.tracing, { + ...nodeStartedData, + status: NodeRunningStatus.Running, + }) }) }, onNodeFinished: ({ data: nodeFinishedData }) => { @@ -825,6 +810,9 @@ export const useChat = ( if (nodeFinishedData.iteration_id) return + if (nodeFinishedData.loop_id) + return + const currentIndex = responseItem.workflowProcess.tracing.findIndex((item) => { if (!item.execution_metadata?.parallel_id) return item.id === nodeFinishedData.id @@ -852,8 +840,7 @@ export const useChat = ( if (!responseItem.workflowProcess?.tracing) return const tracing = responseItem.workflowProcess.tracing - const loopIndex = tracing.findIndex(item => item.node_id === loopFinishedData.node_id - && (item.execution_metadata?.parallel_id === loopFinishedData.execution_metadata?.parallel_id || item.parallel_id === loopFinishedData.execution_metadata?.parallel_id))! + const loopIndex = tracing.findIndex(item => item.id === loopFinishedData.id)! if (loopIndex > -1) { tracing[loopIndex] = { ...tracing[loopIndex], diff --git a/web/app/components/workflow/utils/top-level-tracing.spec.ts b/web/app/components/workflow/utils/top-level-tracing.spec.ts new file mode 100644 index 0000000000..da01cc2a6c --- /dev/null +++ b/web/app/components/workflow/utils/top-level-tracing.spec.ts @@ -0,0 +1,133 @@ +import type { NodeTracing } from '@/types/workflow' +import { NodeRunningStatus } from '@/app/components/workflow/types' +import { upsertTopLevelTracingNodeOnStart } from './top-level-tracing' + +const createTrace = (overrides: Partial = {}): NodeTracing => ({ + id: 'trace-1', + index: 0, + predecessor_node_id: '', + node_id: 'node-1', + node_type: 'llm' as NodeTracing['node_type'], + title: 'Node 1', + inputs: {}, + inputs_truncated: false, + process_data: {}, + process_data_truncated: false, + outputs: {}, + outputs_truncated: false, + status: NodeRunningStatus.Succeeded, + elapsed_time: 0, + metadata: { + iterator_length: 0, + iterator_index: 0, + loop_length: 0, + loop_index: 0, + }, + created_at: 0, + created_by: { + id: 'user-1', + name: 'User', + email: 'user@example.com', + }, + finished_at: 0, + ...overrides, +}) + +describe('upsertTopLevelTracingNodeOnStart', () => { + beforeEach(() => { + vi.clearAllMocks() + }) + + it('should append a new top-level node when no matching trace exists', () => { + const tracing: NodeTracing[] = [] + const startedNode = createTrace({ + id: 'trace-2', + node_id: 'node-2', + status: NodeRunningStatus.Running, + }) + + const updated = upsertTopLevelTracingNodeOnStart(tracing, startedNode) + + expect(updated).toBe(true) + expect(tracing).toEqual([startedNode]) + }) + + it('should update an existing top-level node when the execution id matches', () => { + const tracing: NodeTracing[] = [ + createTrace({ + id: 'trace-1', + node_id: 'node-1', + status: NodeRunningStatus.Succeeded, + }), + ] + const startedNode = createTrace({ + id: 'trace-1', + node_id: 'node-1', + status: NodeRunningStatus.Running, + }) + + const updated = upsertTopLevelTracingNodeOnStart(tracing, startedNode) + + expect(updated).toBe(true) + expect(tracing).toEqual([startedNode]) + }) + + it('should append a new top-level node when the same node starts with a new execution id', () => { + const existingTrace = createTrace({ + id: 'trace-1', + node_id: 'node-1', + status: NodeRunningStatus.Succeeded, + }) + const tracing: NodeTracing[] = [existingTrace] + const startedNode = createTrace({ + id: 'trace-2', + node_id: 'node-1', + status: NodeRunningStatus.Running, + }) + + const updated = upsertTopLevelTracingNodeOnStart(tracing, startedNode) + + expect(updated).toBe(true) + expect(tracing).toEqual([existingTrace, startedNode]) + }) + + it('should ignore nested iteration node starts even when the node id matches a top-level trace', () => { + const existingTrace = createTrace({ + id: 'top-level-trace', + node_id: 'node-1', + status: NodeRunningStatus.Succeeded, + }) + const tracing: NodeTracing[] = [existingTrace] + const nestedIterationTrace = createTrace({ + id: 'iteration-trace', + node_id: 'node-1', + iteration_id: 'iteration-1', + status: NodeRunningStatus.Running, + }) + + const updated = upsertTopLevelTracingNodeOnStart(tracing, nestedIterationTrace) + + expect(updated).toBe(false) + expect(tracing).toEqual([existingTrace]) + }) + + it('should ignore nested loop node starts even when the node id matches a top-level trace', () => { + const existingTrace = createTrace({ + id: 'top-level-trace', + node_id: 'node-1', + status: NodeRunningStatus.Succeeded, + }) + const tracing: NodeTracing[] = [existingTrace] + const nestedLoopTrace = createTrace({ + id: 'loop-trace', + node_id: 'node-1', + loop_id: 'loop-1', + status: NodeRunningStatus.Running, + }) + + const updated = upsertTopLevelTracingNodeOnStart(tracing, nestedLoopTrace) + + expect(updated).toBe(false) + expect(tracing).toEqual([existingTrace]) + }) +}) diff --git a/web/app/components/workflow/utils/top-level-tracing.ts b/web/app/components/workflow/utils/top-level-tracing.ts new file mode 100644 index 0000000000..8ddeb2a957 --- /dev/null +++ b/web/app/components/workflow/utils/top-level-tracing.ts @@ -0,0 +1,22 @@ +import type { NodeTracing } from '@/types/workflow' + +const isNestedTracingNode = (trace: Pick) => { + return Boolean(trace.iteration_id || trace.loop_id) +} + +export const upsertTopLevelTracingNodeOnStart = ( + tracing: NodeTracing[], + startedNode: NodeTracing, +) => { + if (isNestedTracingNode(startedNode)) + return false + + const currentIndex = tracing.findIndex(item => item.id === startedNode.id) + if (currentIndex > -1) + // Started events are the authoritative snapshot for an execution; merging would retain stale client-side fields. + tracing[currentIndex] = startedNode + else + tracing.push(startedNode) + + return true +}