From 65223c80925d3b3ca9a19b082d5321c84ad9c6a4 Mon Sep 17 00:00:00 2001
From: Desel72 <pedroluiscolmenares722@gmail.com>
Date: Mon, 23 Mar 2026 07:55:50 -0500
Subject: [PATCH] test: remove mock-based tests superseded by testcontainers
 (#33946)

---
 .../test_delete_archived_workflow_run.py      | 57 -------------------
 ...kflow_node_execution_service_repository.py | 30 ----------
 2 files changed, 87 deletions(-)
 delete mode 100644 api/tests/unit_tests/services/test_delete_archived_workflow_run.py
 delete mode 100644 api/tests/unit_tests/services/workflow/test_workflow_node_execution_service_repository.py

diff --git a/api/tests/unit_tests/services/test_delete_archived_workflow_run.py b/api/tests/unit_tests/services/test_delete_archived_workflow_run.py
deleted file mode 100644
index a7e1a011f6..0000000000
--- a/api/tests/unit_tests/services/test_delete_archived_workflow_run.py
+++ /dev/null
@@ -1,57 +0,0 @@
-"""
-Unit tests for archived workflow run deletion service.
-"""
-
-from unittest.mock import MagicMock, patch
-
-
-class TestArchivedWorkflowRunDeletion:
-    def test_delete_by_run_id_calls_delete_run(self):
-        from services.retention.workflow_run.delete_archived_workflow_run import ArchivedWorkflowRunDeletion
-
-        deleter = ArchivedWorkflowRunDeletion()
-        repo = MagicMock()
-        repo.get_archived_run_ids.return_value = {"run-1"}
-        run = MagicMock()
-        run.id = "run-1"
-        run.tenant_id = "tenant-1"
-
-        session = MagicMock()
-        session.get.return_value = run
-
-        session_maker = MagicMock()
-        session_maker.return_value.__enter__.return_value = session
-        session_maker.return_value.__exit__.return_value = None
-        mock_db = MagicMock()
-        mock_db.engine = MagicMock()
-
-        with (
-            patch("services.retention.workflow_run.delete_archived_workflow_run.db", mock_db),
-            patch(
-                "services.retention.workflow_run.delete_archived_workflow_run.sessionmaker",
-                return_value=session_maker,
-                autospec=True,
-            ),
-            patch.object(deleter, "_get_workflow_run_repo", return_value=repo, autospec=True),
-            patch.object(
-                deleter, "_delete_run", return_value=MagicMock(success=True), autospec=True
-            ) as mock_delete_run,
-        ):
-            result = deleter.delete_by_run_id("run-1")
-
-        assert result.success is True
-        mock_delete_run.assert_called_once_with(run)
-
-    def test_delete_run_dry_run(self):
-        from services.retention.workflow_run.delete_archived_workflow_run import ArchivedWorkflowRunDeletion
-
-        deleter = ArchivedWorkflowRunDeletion(dry_run=True)
-        run = MagicMock()
-        run.id = "run-1"
-        run.tenant_id = "tenant-1"
-
-        with patch.object(deleter, "_get_workflow_run_repo", autospec=True) as mock_get_repo:
-            result = deleter._delete_run(run)
-
-        assert result.success is True
-        mock_get_repo.assert_not_called()
diff --git a/api/tests/unit_tests/services/workflow/test_workflow_node_execution_service_repository.py b/api/tests/unit_tests/services/workflow/test_workflow_node_execution_service_repository.py
deleted file mode 100644
index 79bf5e94c2..0000000000
--- a/api/tests/unit_tests/services/workflow/test_workflow_node_execution_service_repository.py
+++ /dev/null
@@ -1,30 +0,0 @@
-from unittest.mock import MagicMock
-
-import pytest
-
-from repositories.sqlalchemy_api_workflow_node_execution_repository import (
-    DifyAPISQLAlchemyWorkflowNodeExecutionRepository,
-)
-
-
-class TestSQLAlchemyWorkflowNodeExecutionServiceRepository:
-    @pytest.fixture
-    def repository(self):
-        mock_session_maker = MagicMock()
-        return DifyAPISQLAlchemyWorkflowNodeExecutionRepository(session_maker=mock_session_maker)
-
-    def test_repository_implements_protocol(self, repository):
-        """Test that the repository implements the required protocol methods."""
-        # Verify all protocol methods are implemented
-        assert hasattr(repository, "get_node_last_execution")
-        assert hasattr(repository, "get_executions_by_workflow_run")
-        assert hasattr(repository, "get_execution_by_id")
-
-        # Verify methods are callable
-        assert callable(repository.get_node_last_execution)
-        assert callable(repository.get_executions_by_workflow_run)
-        assert callable(repository.get_execution_by_id)
-        assert callable(repository.delete_expired_executions)
-        assert callable(repository.delete_executions_by_app)
-        assert callable(repository.get_expired_executions_batch)
-        assert callable(repository.delete_executions_by_ids)