mirror of https://github.com/langgenius/dify.git
fix: only register debug endpoints in development mode
The /threads and /db-pool-stat endpoints expose internal server state (thread info, DB pool configuration) without any authentication. Wrap them with a dify_config.DEBUG check so they are only registered when the app is running in debug or testing mode. Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>
This commit is contained in:
parent
194c205ed3
commit
956f211e58
|
|
@ -24,44 +24,46 @@ def init_app(app: DifyApp):
|
|||
content_type="application/json",
|
||||
)
|
||||
|
||||
@app.route("/threads")
|
||||
def threads(): # pyright: ignore[reportUnusedFunction]
|
||||
num_threads = threading.active_count()
|
||||
threads = threading.enumerate()
|
||||
if dify_config.DEBUG or app.config.get("TESTING"):
|
||||
|
||||
thread_list = []
|
||||
for thread in threads:
|
||||
thread_name = thread.name
|
||||
thread_id = thread.ident
|
||||
is_alive = thread.is_alive()
|
||||
@app.route("/threads")
|
||||
def threads(): # pyright: ignore[reportUnusedFunction]
|
||||
num_threads = threading.active_count()
|
||||
threads = threading.enumerate()
|
||||
|
||||
thread_list.append(
|
||||
{
|
||||
"name": thread_name,
|
||||
"id": thread_id,
|
||||
"is_alive": is_alive,
|
||||
}
|
||||
)
|
||||
thread_list = []
|
||||
for thread in threads:
|
||||
thread_name = thread.name
|
||||
thread_id = thread.ident
|
||||
is_alive = thread.is_alive()
|
||||
|
||||
return {
|
||||
"pid": os.getpid(),
|
||||
"thread_num": num_threads,
|
||||
"threads": thread_list,
|
||||
}
|
||||
thread_list.append(
|
||||
{
|
||||
"name": thread_name,
|
||||
"id": thread_id,
|
||||
"is_alive": is_alive,
|
||||
}
|
||||
)
|
||||
|
||||
@app.route("/db-pool-stat")
|
||||
def pool_stat(): # pyright: ignore[reportUnusedFunction]
|
||||
from extensions.ext_database import db
|
||||
return {
|
||||
"pid": os.getpid(),
|
||||
"thread_num": num_threads,
|
||||
"threads": thread_list,
|
||||
}
|
||||
|
||||
engine = db.engine
|
||||
# TODO: Fix the type error
|
||||
# FIXME maybe its sqlalchemy issue
|
||||
return {
|
||||
"pid": os.getpid(),
|
||||
"pool_size": engine.pool.size(), # type: ignore
|
||||
"checked_in_connections": engine.pool.checkedin(), # type: ignore
|
||||
"checked_out_connections": engine.pool.checkedout(), # type: ignore
|
||||
"overflow_connections": engine.pool.overflow(), # type: ignore
|
||||
"connection_timeout": engine.pool.timeout(), # type: ignore
|
||||
"recycle_time": db.engine.pool._recycle, # type: ignore
|
||||
}
|
||||
@app.route("/db-pool-stat")
|
||||
def pool_stat(): # pyright: ignore[reportUnusedFunction]
|
||||
from extensions.ext_database import db
|
||||
|
||||
engine = db.engine
|
||||
# TODO: Fix the type error
|
||||
# FIXME maybe its sqlalchemy issue
|
||||
return {
|
||||
"pid": os.getpid(),
|
||||
"pool_size": engine.pool.size(), # type: ignore
|
||||
"checked_in_connections": engine.pool.checkedin(), # type: ignore
|
||||
"checked_out_connections": engine.pool.checkedout(), # type: ignore
|
||||
"overflow_connections": engine.pool.overflow(), # type: ignore
|
||||
"connection_timeout": engine.pool.timeout(), # type: ignore
|
||||
"recycle_time": db.engine.pool._recycle, # type: ignore
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue