From ab2b3dfa820b4201b49f56bb17d392eba43326c7 Mon Sep 17 00:00:00 2001
From: Desel72 <pedroluiscolmenares722@gmail.com>
Date: Mon, 23 Mar 2026 12:14:54 +0000
Subject: [PATCH] test: migrate dataset service create dataset tests to
 testcontainers

---
 .../test_dataset_service_create_dataset.py    | 60 +++++++++++++++++++
 .../test_dataset_service_create_dataset.py    | 50 ----------------
 2 files changed, 60 insertions(+), 50 deletions(-)
 create mode 100644 api/tests/test_containers_integration_tests/services/test_dataset_service_create_dataset.py
 delete mode 100644 api/tests/unit_tests/services/test_dataset_service_create_dataset.py

diff --git a/api/tests/test_containers_integration_tests/services/test_dataset_service_create_dataset.py b/api/tests/test_containers_integration_tests/services/test_dataset_service_create_dataset.py
new file mode 100644
index 0000000000..91a98712c4
--- /dev/null
+++ b/api/tests/test_containers_integration_tests/services/test_dataset_service_create_dataset.py
@@ -0,0 +1,60 @@
+"""Testcontainers integration tests for DatasetService.create_empty_rag_pipeline_dataset."""
+
+from __future__ import annotations
+
+from unittest.mock import patch
+from uuid import uuid4
+
+import pytest
+
+from models.account import Account, Tenant, TenantAccountJoin
+from services.dataset_service import DatasetService
+from services.entities.knowledge_entities.rag_pipeline_entities import IconInfo, RagPipelineDatasetCreateEntity
+
+
+class TestDatasetServiceCreateRagPipelineDataset:
+    def _create_tenant_and_account(self, db_session_with_containers) -> tuple[Tenant, Account]:
+        tenant = Tenant(name=f"Tenant {uuid4()}")
+        db_session_with_containers.add(tenant)
+        db_session_with_containers.flush()
+
+        account = Account(
+            name=f"Account {uuid4()}",
+            email=f"ds_create_{uuid4()}@example.com",
+            password="hashed",
+            password_salt="salt",
+            interface_language="en-US",
+            timezone="UTC",
+        )
+        db_session_with_containers.add(account)
+        db_session_with_containers.flush()
+
+        join = TenantAccountJoin(
+            tenant_id=tenant.id,
+            account_id=account.id,
+            role="owner",
+            current=True,
+        )
+        db_session_with_containers.add(join)
+        db_session_with_containers.commit()
+        return tenant, account
+
+    def _build_entity(self, name: str = "Test Dataset") -> RagPipelineDatasetCreateEntity:
+        icon_info = IconInfo(icon="\U0001f4d9", icon_background="#FFF4ED", icon_type="emoji")
+        return RagPipelineDatasetCreateEntity(
+            name=name,
+            description="",
+            icon_info=icon_info,
+            permission="only_me",
+        )
+
+    def test_create_rag_pipeline_dataset_raises_when_current_user_id_is_none(self, db_session_with_containers):
+        tenant, _ = self._create_tenant_and_account(db_session_with_containers)
+
+        mock_user = type("FakeUser", (), {"id": None})()
+        with patch("services.dataset_service.current_user", mock_user):
+            with pytest.raises(ValueError, match="Current user or current user id not found"):
+                DatasetService.create_empty_rag_pipeline_dataset(
+                    tenant_id=tenant.id,
+                    rag_pipeline_dataset_create_entity=self._build_entity(),
+                )
diff --git a/api/tests/unit_tests/services/test_dataset_service_create_dataset.py b/api/tests/unit_tests/services/test_dataset_service_create_dataset.py
deleted file mode 100644
index f8c5270656..0000000000
--- a/api/tests/unit_tests/services/test_dataset_service_create_dataset.py
+++ /dev/null
@@ -1,50 +0,0 @@
-"""Unit tests for non-SQL validation paths in DatasetService dataset creation."""
-
-from unittest.mock import Mock, patch
-from uuid import uuid4
-
-import pytest
-
-from services.dataset_service import DatasetService
-from services.entities.knowledge_entities.rag_pipeline_entities import IconInfo, RagPipelineDatasetCreateEntity
-
-
-class TestDatasetServiceCreateRagPipelineDatasetNonSQL:
-    """Unit coverage for non-SQL validation in create_empty_rag_pipeline_dataset."""
-
-    @pytest.fixture
-    def mock_rag_pipeline_dependencies(self):
-        """Patch database session and current_user for validation-only unit coverage."""
-        with (
-            patch("services.dataset_service.db.session") as mock_db,
-            patch("services.dataset_service.current_user") as mock_current_user,
-        ):
-            yield {
-                "db_session": mock_db,
-                "current_user_mock": mock_current_user,
-            }
-
-    def test_create_rag_pipeline_dataset_missing_current_user_error(self, mock_rag_pipeline_dependencies):
-        """Raise ValueError when current_user.id is unavailable before SQL persistence."""
-        # Arrange
-        tenant_id = str(uuid4())
-        mock_rag_pipeline_dependencies["current_user_mock"].id = None
-
-        mock_query = Mock()
-        mock_query.filter_by.return_value.first.return_value = None
-        mock_rag_pipeline_dependencies["db_session"].query.return_value = mock_query
-
-        icon_info = IconInfo(icon="📙", icon_background="#FFF4ED", icon_type="emoji")
-        entity = RagPipelineDatasetCreateEntity(
-            name="Test Dataset",
-            description="",
-            icon_info=icon_info,
-            permission="only_me",
-        )
-
-        # Act / Assert
-        with pytest.raises(ValueError, match="Current user or current user id not found"):
-            DatasetService.create_empty_rag_pipeline_dataset(
-                tenant_id=tenant_id,
-                rag_pipeline_dataset_create_entity=entity,
-            )