suguo
/
gocron
mirror of https://github.com/go-co-op/gocron.git
1
0
Fork 0
Code Projects Releases Activity

don't touch global logger in log tests

This commit is contained in:
John Roesler 2023-11-14 13:45:46 -06:00
parent 28c482dab5
commit 9a3fd98dcc
No known key found for this signature in database
GPG Key ID: 3AA260B9FCA0A6E1
2 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
logger.go
View File

@ -4,6 +4,7 @@ package gocron
import ( import (
"fmt" "fmt"
"log" "log"
"os"
"strings" "strings"
) )
@ -43,40 +44,45 @@ const (
) )
type logger struct { type logger struct {
log *log.Logger
level LogLevel level LogLevel
} }
// NewLogger returns a new Logger that logs at the given level. // NewLogger returns a new Logger that logs at the given level.
func NewLogger(level LogLevel) Logger { func NewLogger(level LogLevel) Logger {
return &logger{level: level} l := log.New(os.Stdout, "", log.LstdFlags)
return &logger{
log: l,
level: level,
}
} }
func (l *logger) Debug(msg string, args ...any) { func (l *logger) Debug(msg string, args ...any) {
if l.level < LogLevelDebug { if l.level < LogLevelDebug {
return return
} }
log.Printf("DEBUG: %s%s\n", msg, logFormatArgs(args...)) l.log.Printf("DEBUG: %s%s\n", msg, logFormatArgs(args...))
} }
func (l *logger) Error(msg string, args ...any) { func (l *logger) Error(msg string, args ...any) {
if l.level < LogLevelError { if l.level < LogLevelError {
return return
} }
log.Printf("ERROR: %s%s\n", msg, logFormatArgs(args...)) l.log.Printf("ERROR: %s%s\n", msg, logFormatArgs(args...))
} }
func (l *logger) Info(msg string, args ...any) { func (l *logger) Info(msg string, args ...any) {
if l.level < LogLevelInfo { if l.level < LogLevelInfo {
return return
} }
log.Printf("INFO: %s%s\n", msg, logFormatArgs(args...)) l.log.Printf("INFO: %s%s\n", msg, logFormatArgs(args...))
} }
func (l *logger) Warn(msg string, args ...any) { func (l *logger) Warn(msg string, args ...any) {
if l.level < LogLevelWarn { if l.level < LogLevelWarn {
return return
} }
log.Printf("WARN: %s%s\n", msg, logFormatArgs(args...)) l.log.Printf("WARN: %s%s\n", msg, logFormatArgs(args...))
} }
func logFormatArgs(args ...any) string { func logFormatArgs(args ...any) string {

6
logger_test.go
View File

@ -47,8 +47,10 @@ func TestNewLogger(t *testing.T) {
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
var results bytes.Buffer var results bytes.Buffer
log.SetOutput(&results) l := &logger{
l := NewLogger(tt.level) level: tt.level,
log: log.New(&results, "", log.LstdFlags),
}
var noArgs []any var noArgs []any
oneArg := []any{"arg1"} oneArg := []any{"arg1"}