diff --git a/google/cloud/asset/v1beta1/asset_service.proto b/google/cloud/asset/v1beta1/asset_service.proto index da859d10..b64502f6 100644 --- a/google/cloud/asset/v1beta1/asset_service.proto +++ b/google/cloud/asset/v1beta1/asset_service.proto @@ -1,4 +1,4 @@ -// Copyright 2018 Google LLC +// Copyright 2018 Google LLC. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. @@ -11,6 +11,7 @@ // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. +// syntax = "proto3"; @@ -32,7 +33,7 @@ option php_namespace = "Google\\Cloud\\Asset\\V1beta1"; // Asset service definition. service AssetService { // Exports assets with time and resource types to a given Google Cloud Storage - // location. The output format is newline delimited JSON. + // location. The output format is newline-delimited JSON. // This API implements the [google.longrunning.Operation][google.longrunning.Operation] API allowing users // to keep track of the export. rpc ExportAssets(ExportAssetsRequest) returns (google.longrunning.Operation) { @@ -63,24 +64,25 @@ service AssetService { // Export asset request. message ExportAssetsRequest { - // Required. The relative name of the root asset. It can only be an - // organization number (e.g. "organizations/123") or a project number - // (e.g. "projects/12345"). + // Required. The relative name of the root asset. Can only be an organization + // number (such as "organizations/123"), or a project id (such as + // "projects/my-project-id") or a project number (such as "projects/12345"). string parent = 1; - // Timestamp to take an asset snapshot. This can only be current or past - // time. If not specified, the current time will be used. Due to delays in - // resource data collection and indexing, there is a volatile window during - // which running the same query may get different results. + // Timestamp to take an asset snapshot. This can only be set to a timestamp in + // the past or of the current time. If not specified, the current time will be + // used. Due to delays in resource data collection and indexing, there is a + // volatile window during which running the same query may get different + // results. google.protobuf.Timestamp read_time = 2; - // A list of asset types to take a snapshot for. Example: + // A list of asset types of which to take a snapshot for. Example: // "google.compute.disk". If specified, only matching assets will be returned. repeated string asset_types = 3; - // A list of asset content types. If specified, only matching content will be - // returned. Otherwise, no content but the asset name will be returned. - repeated ContentType content_types = 4; + // Asset content type. If not specified, no content but the asset name will be + // returned. + ContentType content_type = 4; // Required. Output configuration indicating where the results will be output // to. All results will be in newline delimited JSON format. @@ -91,10 +93,10 @@ message ExportAssetsRequest { // [google.longrunning.Operations.GetOperation][google.longrunning.Operations.GetOperation] method in the returned // [google.longrunning.Operation.response][google.longrunning.Operation.response] field. message ExportAssetsResponse { - // Required. Time the snapshot was taken. + // Time the snapshot was taken. google.protobuf.Timestamp read_time = 1; - // Required. Output configuration indicating where the results were output to. + // Output configuration indicating where the results were output to. // All results are in JSON format. OutputConfig output_config = 2; } @@ -102,8 +104,8 @@ message ExportAssetsResponse { // Batch get assets history request. message BatchGetAssetsHistoryRequest { // Required. The relative name of the root asset. It can only be an - // organization ID (e.g. "organizations/123") or a project ID - // (e.g. "projects/12345"). + // organization number (such as "organizations/123"), or a project id (such as + // "projects/my-project-id")"or a project number (such as "projects/12345"). string parent = 1; // A list of the full names of the assets. See: @@ -111,15 +113,16 @@ message BatchGetAssetsHistoryRequest { // Example: // "//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1". // - // The request becomes a no-op if the asset name list is empty. + // The request becomes a no-op if the asset name list is empty, and the max + // size of the asset name list is 100 in one request. repeated string asset_names = 2; // Required. The content type. ContentType content_type = 3; - // Required. The time window for the asset history. The returned results - // contain all temporal assets whose time window overlap with - // read_time_window. + // Required. The time window for the asset history. The start time is + // required. The returned results contain all temporal assets whose time + // window overlap with read_time_window. TimeWindow read_time_window = 4; } diff --git a/google/cloud/asset/v1beta1/assets.proto b/google/cloud/asset/v1beta1/assets.proto index ca4f144f..db270b08 100644 --- a/google/cloud/asset/v1beta1/assets.proto +++ b/google/cloud/asset/v1beta1/assets.proto @@ -1,4 +1,4 @@ -// Copyright 2018 Google LLC +// Copyright 2018 Google LLC. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. @@ -11,6 +11,7 @@ // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. +// syntax = "proto3"; @@ -46,11 +47,10 @@ message TemporalAsset { // A time window of [start_time, end_time). message TimeWindow { // Start time of the time window (inclusive). - // Infinite past if not specified. google.protobuf.Timestamp start_time = 1; // End time of the time window (exclusive). - // Infinite future if not specified. + // Current timestamp if not specified. google.protobuf.Timestamp end_time = 2; }