suguo
/
googleapis
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make importing rule with the same name (but different aliases) from different repositories possible. 

This is needed to allow monolitic gapic-generator and microgenerators coexist during transition period.

To plug a microgenerator:

1) Add corresponding rules bidnings under `switched_rules_by_language` in repository_rules.bzl:
    rules["go_gapic_library2"] = _switch(
        go and grpc and gapic,
        "@gapic_generator_go//rules_go_gapic/go_gapic.bzl",
        "go_gapic_library",
    )

2) Import microgenerator in WORKSPACE (the above example assumes that the generator was imported under name "gapic_generator_go").

3) To migrate an API from monolith to micro generator (this is done per API and per language) modify the corresponding load statement in the API's BUILD.bazel file. For example, for the example above, to migrate to go microgenerator modify the go-specific load statement in BUILD.bazel file of a specific API (which you want to migrate) to the following:

load(
    "@com_google_googleapis_imports//:imports.bzl",
    "go_gapic_assembly_pkg",
    go_gapic_library = "go_gapic_library2",
    "go_proto_library",
    "go_test",
)

PiperOrigin-RevId: 286065440
This commit is contained in:
Google APIs 2019-12-17 14:52:42 -08:00 committed by Copybara-Service
parent 6ad2bb13bc
commit 3352100a15
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
repository_rules.bzl
View File

@ -11,7 +11,7 @@ def {rule_name}(**kwargs):
{rule_name} = {native_rule_name}
"""
enabled_rule_script = """
load("{file_label}", _{rule_name} = "{rule_name}")
load("{file_label}", _{rule_name} = "{loaded_rule_name}")
"""
elabled_rule_scrip_alias = """
{rule_name} = _{rule_name}
@ -19,11 +19,18 @@ load("{file_label}", _{rule_name} = "{rule_name}")
load_rules = [] # load() must go before everythin else in .bzl files since Bazel 0.25.0
rules = []
for rule_name, value in ctx.attr.rules.items():
for rule_name, value_and_name in ctx.attr.rules.items():
value = value_and_name[0]
loaded_rule_name = value_and_name[1] if value_and_name[1] else rule_name
if not value:
rules.append(disabled_rule_script.format(rule_name = rule_name))
elif value.startswith("@"):
load_rules.append(enabled_rule_script.format(file_label = value, rule_name = rule_name))
load_rules.append(enabled_rule_script.format(
file_label = value,
rule_name = rule_name,
loaded_rule_name = loaded_rule_name,
))
rules.append(elabled_rule_scrip_alias.format(rule_name = rule_name))
elif value.startswith("native."):
rules.append(
@ -38,7 +45,7 @@ load("{file_label}", _{rule_name} = "{rule_name}")
switched_rules = repository_rule(
implementation = _switched_rules_impl,
attrs = {
"rules": attr.string_dict(
"rules": attr.string_list_dict(
allow_empty = True,
mandatory = False,
default = {},
@ -280,5 +287,8 @@ def switched_rules_by_language(
rules = rules,
)
def _switch(enabled, enabled_value = ""):
return enabled_value if enabled else ""
def _switch(enabled, enabled_value = "", actual_name = ""):
if enabled:
return [enabled_value, actual_name]
else:
return ["", actual_name]