From 623a1aa03ae7a031b50be54df78263da2f22e981 Mon Sep 17 00:00:00 2001 From: Google APIs Date: Tue, 18 Aug 2020 13:17:43 -0700 Subject: [PATCH] docs: Clarified that event_time can also be considered as the "update time" for a Finding. It also captures when a Finding was updated. The previous wording could've been interpreted as only the creation time. PiperOrigin-RevId: 327292977 --- google/cloud/securitycenter/v1/finding.proto | 8 +++++--- google/cloud/securitycenter/v1beta1/finding.proto | 13 ++++++++----- google/cloud/securitycenter/v1p1beta1/finding.proto | 8 +++++--- 3 files changed, 18 insertions(+), 11 deletions(-) diff --git a/google/cloud/securitycenter/v1/finding.proto b/google/cloud/securitycenter/v1/finding.proto index 4ccdc495..cf0873cf 100644 --- a/google/cloud/securitycenter/v1/finding.proto +++ b/google/cloud/securitycenter/v1/finding.proto @@ -101,9 +101,11 @@ message Finding { // to the finding. SecurityMarks security_marks = 8 [(google.api.field_behavior) = OUTPUT_ONLY]; - // The time at which the event took place. For example, if the finding - // represents an open firewall it would capture the time the detector believes - // the firewall became open. The accuracy is determined by the detector. + // The time at which the event took place, or when an update to the finding + // occurred. For example, if the finding represents an open firewall it would + // capture the time the detector believes the firewall became open. The + // accuracy is determined by the detector. If the finding were to be resolved + // afterward, this time would reflect when the finding was resolved. google.protobuf.Timestamp event_time = 9; // The time at which the finding was created in Security Command Center. diff --git a/google/cloud/securitycenter/v1beta1/finding.proto b/google/cloud/securitycenter/v1beta1/finding.proto index d78a522b..647b3b43 100644 --- a/google/cloud/securitycenter/v1beta1/finding.proto +++ b/google/cloud/securitycenter/v1beta1/finding.proto @@ -16,12 +16,12 @@ syntax = "proto3"; package google.cloud.securitycenter.v1beta1; +import "google/api/annotations.proto"; import "google/api/field_behavior.proto"; import "google/api/resource.proto"; import "google/cloud/securitycenter/v1beta1/security_marks.proto"; import "google/protobuf/struct.proto"; import "google/protobuf/timestamp.proto"; -import "google/api/annotations.proto"; option go_package = "google.golang.org/genproto/googleapis/cloud/securitycenter/v1beta1;securitycenter"; option java_multiple_files = true; @@ -58,7 +58,8 @@ message Finding { // "organizations/{organization_id}/sources/{source_id}/findings/{finding_id}" string name = 1; - // Immutable. The relative resource name of the source the finding belongs to. See: + // Immutable. The relative resource name of the source the finding belongs to. + // See: // https://cloud.google.com/apis/design/resource_names#relative_resource_name // This field is immutable after creation time. // For example: @@ -97,9 +98,11 @@ message Finding { // to the finding. SecurityMarks security_marks = 8 [(google.api.field_behavior) = OUTPUT_ONLY]; - // The time at which the event took place. For example, if the finding - // represents an open firewall it would capture the time the detector believes - // the firewall became open. The accuracy is determined by the detector. + // The time at which the event took place, or when an update to the finding + // occurred. For example, if the finding represents an open firewall it would + // capture the time the detector believes the firewall became open. The + // accuracy is determined by the detector. If the finding were to be resolved + // afterward, this time would reflect when the finding was resolved. google.protobuf.Timestamp event_time = 9; // The time at which the finding was created in Security Command Center. diff --git a/google/cloud/securitycenter/v1p1beta1/finding.proto b/google/cloud/securitycenter/v1p1beta1/finding.proto index 75f52dfe..49f8159f 100644 --- a/google/cloud/securitycenter/v1p1beta1/finding.proto +++ b/google/cloud/securitycenter/v1p1beta1/finding.proto @@ -118,9 +118,11 @@ message Finding { // to the finding. SecurityMarks security_marks = 8 [(google.api.field_behavior) = OUTPUT_ONLY]; - // The time at which the event took place. For example, if the finding - // represents an open firewall it would capture the time the detector believes - // the firewall became open. The accuracy is determined by the detector. + // The time at which the event took place, or when an update to the finding + // occurred. For example, if the finding represents an open firewall it would + // capture the time the detector believes the firewall became open. The + // accuracy is determined by the detector. If the finding were to be resolved + // afterward, this time would reflect when the finding was resolved. google.protobuf.Timestamp event_time = 9; // The time at which the finding was created in Security Command Center.