After introducing a second run of reference tests (with Windows-style
newlines), tests hit the 10m deadline very hard. Bump the timeout by a
lot to see how much is actually needed. The right fix is probably to
drop the race detector, since we don't have any parallelism and it
doesn't buy us much, only burns the CPU cycles, but that should be
addressed separately.
This mainly adds a re-run of all reference tests with Unix newlines
replaced with Windows ones. Plus, fixes for a bazillion of problems that
this test uncovered.
Node now contains a ContainsWindowsNewlines field, which is set to true
when the contents of the node (either in .Literal or in .content)
include text having '\r' characters. This is then checked at render time
for replacement back to Unix newlines.
The old regex missed a lot of HTML entities, like long references
(from 6-character entites like ≈ to the somewhat rarer
∳) as well as numeric references
(decimal e.g. Ӓ or hex e.g. 𓫶). This fixes that.
* Add full info string in fenced code blocks
According to common mark, the info string for a fenced code block can be any
non-whitespace string, so adjust the code to read a full string instead of
just the syntax name.
Fixes#410 in v2.
* run go fmt
Unexport a bunch of constants private to HTML renderer
They were cluttering the documentation and are not useful otherwise.
Rearrange constants in descending dependencies order
Improve Renderer to be less confusing. Fix documentation for it.
OmitContents flag got dropped along the way. First, it would fit poorly
into the new design and second, it's unclear how widely this feature is
used. But most importantly, it's trivial to roll your own with the v2
API: https://gist.github.com/rtfb/2693f6bfcc1760661e8d2fb832763a15Fixes#368.
The check was introduced with d28de22, when fixing #172 and #173.
Then I removed it with bcd6dd8 when fixing #180
And then it was reintroduced with 232d06c when fixing regression.
It seems that the check can be removed again. All these cases now have
tests (including the one from 69f51af, which seems to have landed to v1
only, copying it here) and they all pass.
Vytautas Šaltenis
Liming Jin
Emil Melnikov
Rebecca Turner
Nick Galbreath
Nathan Glenn
Kentaro Matsushita
Mitchell Cohen
Iain Haslam
Vas Sudanagunta
Dmitri Shuralyov
Bjørn Erik Pedersen
Pierre Neidhardt